Add test execution to pre-push hook #9029
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
|
Review complete. Found 1 critical issue that needs to be addressed before merging.
Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| fi | ||
|
|
||
| $pnpm_cmd run check-types | ||
| $pnpm_cmd run test |
There was a problem hiding this comment.
The test command on line 20 will not block the push when tests fail. Bash continues executing after a command fails unless explicitly told to exit. The script will proceed to check changesets and complete the hook even if tests fail, allowing broken code to be pushed.
Suggested change
| $pnpm_cmd run test | |
| $pnpm_cmd run test || exit 1 |
Fix it with Roo Code or mention @roomote and request a fix.
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures all tests pass before pushing, preventing broken code from entering the repository.
$pnpm_cmd run testto.husky/pre-push